Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entities iterator #8

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Entities iterator #8

wants to merge 19 commits into from

Conversation

Alystrasz
Copy link
Member

Adding an iterator that can browse big entities collections following links.

@github-actions
Copy link

github-actions bot commented Oct 22, 2021 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/bundle.js 15.11 KB (+2.13% 🔺) 303 ms (+2.13% 🔺) 121 ms (-33.06% 🔽) 423 ms

Alystrasz
Alystrasz commented Oct 22, 2021
View reviewed changes
src/dao/iterator/EntityIterator.ts Show resolved Hide resolved
src/dao/iterator/EntityIterator.ts
this._nextLink = '';
}

public async hasNext(): Promise<boolean> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an integration test on distant backend, to check if it can go through 10s of pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Alystrasz